refactor(FE): Remove unused search params and yup import

This commit is contained in:
rstubryan
2026-02-05 11:02:20 +07:00
parent b45c7c8ea6
commit 4aa9d54b1e
2 changed files with 15 additions and 26 deletions
+15 -25
View File
@@ -3,7 +3,6 @@ import { CellContext } from '@tanstack/react-table';
import { useSearchParams } from 'next/navigation';
import useSWR from 'swr';
import { useFormik } from 'formik';
import * as yup from 'yup';
import Button from '@/components/Button';
import Card from '@/components/Card';
@@ -174,7 +173,6 @@ const FinanceTable = () => {
});
// ===== State =====
const [searchParams, setSearchParams] = useSearchParams();
const deleteModal = useModal();
const [selectedTransactionType, setSelectedTransactionType] = useState<
OptionType | OptionType[] | null
@@ -254,6 +252,20 @@ const FinanceTable = () => {
loadMore: bankLoadMore,
} = useSelect<Bank>(BankApi.basePath, 'id', 'alias');
const bankSelectOptions = useMemo(() => {
if (!isResponseSuccess(bankRawData)) return [];
return bankOptions.map((bank) => {
const bankData = bankRawData.data.find((data) => data.id === bank?.value);
return {
label: bankData
? `${bankData.alias} - ${bankData.account_number} - ${bankData.owner}`
: '',
value: bank?.value,
};
});
}, [bankOptions, bankRawData]);
// ===== Handler =====
const searchChangeHandler = (e: React.ChangeEvent<HTMLInputElement>) => {
filterFormik.setFieldValue('search', e.target.value);
@@ -311,10 +323,6 @@ const FinanceTable = () => {
val ? ((val as OptionType).value as string) : ''
);
};
const pageSizeChangeHandler = (val: OptionType | OptionType[] | null) => {
const newVal = val as OptionType;
setPageSize(newVal.value as number);
};
const resetFilterHandler = () => {
setSelectedTransactionType(null);
setSelectedBank(null);
@@ -454,18 +462,15 @@ const FinanceTable = () => {
}, []);
useEffect(() => {
// Store current path on mount
previousPathRef.current = window.location.pathname;
return () => {
const currentPath = window.location.pathname;
// if both paths are within /finance module
const isCurrentPathFinance = currentPath.includes('/finance');
const isPreviousPathFinance =
previousPathRef.current?.includes('/finance');
// reset if we outside finance module entirely
if (isPreviousPathFinance && !isCurrentPathFinance) {
resetSearchValue();
}
@@ -558,22 +563,7 @@ const FinanceTable = () => {
isMulti
/>
<SelectInput
options={
isResponseSuccess(bankRawData)
? bankOptions.map((bank) => ({
label:
bankRawData.data.find((data) => data.id === bank?.value)
?.alias +
' - ' +
bankRawData.data.find((data) => data.id === bank?.value)
?.account_number +
' - ' +
bankRawData.data.find((data) => data.id === bank?.value)
?.owner,
value: bank?.value,
}))
: []
}
options={bankSelectOptions}
label='Bank'
value={selectedBank}
onChange={bankChangeHandler}
@@ -1,4 +1,3 @@
import { OptionType } from '@/components/input/SelectInput';
import * as yup from 'yup';
export type FinanceTableFilterType = {