From f167916a21df70d401b473a0354510c05d0de77a Mon Sep 17 00:00:00 2001 From: ValdiANS Date: Wed, 3 Jun 2026 14:20:43 +0700 Subject: [PATCH] fix: replace throw error with axios error handling in SalesOrderService and MarketingExportService All catch blocks in singleApproval, bulkApprovals (both classes), and delivery now return error.response?.data for axios errors and undefined otherwise, consistent with the BaseApiService pattern. Co-Authored-By: Claude Sonnet 4.6 --- src/services/api/marketing/marketing.ts | 28 ++++++++++++++++++------- 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/src/services/api/marketing/marketing.ts b/src/services/api/marketing/marketing.ts index 2cd225a5..4ded8cc2 100644 --- a/src/services/api/marketing/marketing.ts +++ b/src/services/api/marketing/marketing.ts @@ -45,8 +45,11 @@ export class SalesOrderService extends BaseApiService< notes: notes || `${action} marketing ${id}`, }, }); - } catch (error) { - throw error; + } catch (error: unknown) { + if (axios.isAxiosError>(error)) { + return error.response?.data; + } + return undefined; } } @@ -68,8 +71,11 @@ export class SalesOrderService extends BaseApiService< notes: notes || `${action} marketing ${ids.join(', ')}`, }, }); - } catch (error) { - throw error; + } catch (error: unknown) { + if (axios.isAxiosError>(error)) { + return error.response?.data; + } + return undefined; } } @@ -110,8 +116,11 @@ export class SalesOrderService extends BaseApiService< notes: notes || `Delivery marketing ${id}`, }, }); - } catch (error) { - throw error; + } catch (error: unknown) { + if (axios.isAxiosError>(error)) { + return error.response?.data; + } + return undefined; } } } @@ -142,8 +151,11 @@ class MarketingExportService extends BaseApiService< notes: notes, }, }); - } catch (error) { - throw error; + } catch (error: unknown) { + if (axios.isAxiosError>(error)) { + return error.response?.data; + } + return undefined; } }