From c770651a01a9bfdc899d19adf842894ada95684c Mon Sep 17 00:00:00 2001
From: rstubryan <restubumirr@gmail.com>
Date: Wed, 12 Nov 2025 12:58:08 +0700
Subject: [PATCH] refactor(FE-212): simplify validation for supplier, area,
 location, and warehouse fields in PurchaseRequisitionsForm

---
 .../PurchaseRequisitionsForm.schema.ts        | 20 ++++---------------
 1 file changed, 4 insertions(+), 16 deletions(-)

diff --git a/src/components/pages/purchase/form/request/PurchaseRequisitionsForm.schema.ts b/src/components/pages/purchase/form/request/PurchaseRequisitionsForm.schema.ts
index 784719f4..f158f6ab 100644
--- a/src/components/pages/purchase/form/request/PurchaseRequisitionsForm.schema.ts
+++ b/src/components/pages/purchase/form/request/PurchaseRequisitionsForm.schema.ts
@@ -93,10 +93,7 @@ export const PurchaseRequisitionsFormSchema: Yup.ObjectSchema<PurchaseRequisitio
     }).nullable(),
     supplier_id: Yup.number()
       .required('Supplier wajib dipilih!')
-      .test('is-valid-supplier', 'Supplier wajib dipilih!', function (value) {
-        if (!this.parent.supplier) return true;
-        return Boolean(value && value > 0);
-      })
+      .min(1, 'Supplier wajib dipilih!')
       .typeError('Supplier wajib dipilih!'),
     area: Yup.object({
       value: Yup.number().min(1).required(),
@@ -104,10 +101,7 @@ export const PurchaseRequisitionsFormSchema: Yup.ObjectSchema<PurchaseRequisitio
     }).nullable(),
     area_id: Yup.number()
       .required('Area wajib dipilih!')
-      .test('is-valid-area', 'Area wajib dipilih!', function (value) {
-        if (!this.parent.area) return true;
-        return Boolean(value && value > 0);
-      })
+      .min(1, 'Area wajib dipilih!')
       .typeError('Area wajib dipilih!'),
     location: Yup.object({
       value: Yup.number().min(1).required(),
@@ -115,10 +109,7 @@ export const PurchaseRequisitionsFormSchema: Yup.ObjectSchema<PurchaseRequisitio
     }).nullable(),
     location_id: Yup.number()
       .required('Lokasi wajib dipilih!')
-      .test('is-valid-location', 'Lokasi wajib dipilih!', function (value) {
-        if (!this.parent.location) return true;
-        return Boolean(value && value > 0);
-      })
+      .min(1, 'Lokasi wajib dipilih!')
       .typeError('Lokasi wajib dipilih!'),
     warehouse: Yup.object({
       value: Yup.number().min(1).required(),
@@ -126,10 +117,7 @@ export const PurchaseRequisitionsFormSchema: Yup.ObjectSchema<PurchaseRequisitio
     }),
     warehouse_id: Yup.number()
       .required('Gudang wajib dipilih!')
-      .test('is-valid-warehouse', 'Gudang wajib dipilih!', function (value) {
-        if (!this.parent.warehouse) return true;
-        return Boolean(value && value > 0);
-      })
+      .min(1, 'Gudang wajib dipilih!')
       .typeError('Gudang wajib dipilih!'),
     notes: Yup.string().nullable().default(null),
     items: Yup.array()