refactor(FE): Refactor tab actions to use memoized component

This commit is contained in:
rstubryan
2026-03-05 10:57:13 +07:00
parent c98e7d8cb3
commit b5fc1d4310
@@ -1,4 +1,4 @@
import { useState, useMemo, useCallback, useEffect } from 'react'; import { useState, useMemo, useCallback, useEffect, useRef } from 'react';
import useSWR from 'swr'; import useSWR from 'swr';
import { Icon } from '@iconify/react'; import { Icon } from '@iconify/react';
import Card from '@/components/Card'; import Card from '@/components/Card';
@@ -66,6 +66,8 @@ const CustomerPaymentTab = ({ tabId }: CustomerPaymentTabProps) => {
const [dateErrorShown, setDateErrorShown] = useState(false); const [dateErrorShown, setDateErrorShown] = useState(false);
const [hasDateError, setHasDateError] = useState(false); const [hasDateError, setHasDateError] = useState(false);
const handleFilterModalOpenRef = useRef(() => {});
const filterModal = useModal(); const filterModal = useModal();
const dataTypeOptions = useMemo( const dataTypeOptions = useMemo(
@@ -83,11 +85,6 @@ const CustomerPaymentTab = ({ tabId }: CustomerPaymentTabProps) => {
loadMore: loadMoreCustomers, loadMore: loadMoreCustomers,
} = useSelect(CustomerApi.basePath, 'id', 'name', 'search'); } = useSelect(CustomerApi.basePath, 'id', 'name', 'search');
const handleFilterModalOpen = () => {
filterModal.openModal();
formik.validateForm();
};
// ===== FORMIK SETUP ===== // ===== FORMIK SETUP =====
const formik = useFormik<CustomerPaymentFilterType>({ const formik = useFormik<CustomerPaymentFilterType>({
initialValues: { initialValues: {
@@ -122,6 +119,12 @@ const CustomerPaymentTab = ({ tabId }: CustomerPaymentTabProps) => {
}, },
}); });
// Set the ref callback after formik is initialized
handleFilterModalOpenRef.current = () => {
filterModal.openModal();
formik.validateForm();
};
const getPaymentStatusBadgeColor = (notes: string): Color => { const getPaymentStatusBadgeColor = (notes: string): Color => {
const normalizedValue = notes.toLowerCase(); const normalizedValue = notes.toLowerCase();
@@ -212,7 +215,7 @@ const CustomerPaymentTab = ({ tabId }: CustomerPaymentTabProps) => {
dataTypeOptions.find((opt) => opt.value === formik.values.filter_by) || dataTypeOptions.find((opt) => opt.value === formik.values.filter_by) ||
null null
); );
}, [formik.values.filter_by]); }, [formik.values.filter_by, dataTypeOptions]);
// ===== DATA FETCHING ===== // ===== DATA FETCHING =====
const { data: customerPayment, isLoading } = useSWR( const { data: customerPayment, isLoading } = useSWR(
@@ -349,18 +352,25 @@ const CustomerPaymentTab = ({ tabId }: CustomerPaymentTabProps) => {
} }
}, [customerPaymentExport, filterParams, customerOptions]); }, [customerPaymentExport, filterParams, customerOptions]);
// ===== REGISTER TAB ACTIONS TO STORE ===== // ===== TAB ACTIONS COMPONENT =====
const TabActions = useMemo(() => {
return function TabActionsComponent() {
const setTabActions = useTabActionsStore((state) => state.setTabActions); const setTabActions = useTabActionsStore((state) => state.setTabActions);
const clearTabActions = useTabActionsStore((state) => state.clearTabActions); const clearTabActions = useTabActionsStore(
(state) => state.clearTabActions
);
const formikValuesRef = useRef(formik.values);
formikValuesRef.current = formik.values;
useEffect(() => { useEffect(() => {
setTabActions( setTabActions(
tabId, tabId,
<div className='flex flex-row gap-3'> <div className='flex flex-row gap-3'>
<ButtonFilter <ButtonFilter
values={formik.values} values={formikValuesRef.current}
fieldGroups={[['start_date', 'end_date']]} fieldGroups={[['start_date', 'end_date']]}
onClick={handleFilterModalOpen} onClick={() => handleFilterModalOpenRef.current()}
variant='outline' variant='outline'
className='px-3 py-2.5' className='px-3 py-2.5'
/> />
@@ -390,7 +400,11 @@ const CustomerPaymentTab = ({ tabId }: CustomerPaymentTabProps) => {
<div className='w-px self-stretch bg-base-content/10' /> <div className='w-px self-stretch bg-base-content/10' />
<Icon icon='heroicons:chevron-down' width={14} height={14} /> <Icon
icon='heroicons:chevron-down'
width={14}
height={14}
/>
</div> </div>
</Button> </Button>
} }
@@ -418,21 +432,27 @@ const CustomerPaymentTab = ({ tabId }: CustomerPaymentTabProps) => {
</Dropdown> </Dropdown>
</div> </div>
); );
}, [ }, [setTabActions]);
tabId,
formik.values,
isAnyExportLoading,
handleExportExcel,
handleExportPdf,
filterModal.open,
setTabActions,
]);
useEffect(() => { useEffect(() => {
return () => { return () => {
clearTabActions(tabId); clearTabActions(tabId);
}; };
}, [tabId, clearTabActions]); }, [clearTabActions]);
return null;
};
}, [
tabId,
isAnyExportLoading,
handleExportExcel,
handleExportPdf,
isExcelExportLoading,
isPdfExportLoading,
formik.values,
]);
const TabActionsElement = useMemo(() => <TabActions />, [TabActions]);
const getTableColumns = ( const getTableColumns = (
summary: CustomerPaymentSummary summary: CustomerPaymentSummary
@@ -682,6 +702,7 @@ const CustomerPaymentTab = ({ tabId }: CustomerPaymentTabProps) => {
return ( return (
<> <>
{TabActionsElement}
<div className='w-full p-0 sm:p-3 flex flex-col gap-3'> <div className='w-full p-0 sm:p-3 flex flex-col gap-3'>
{!isSubmitted ? ( {!isSubmitted ? (
<CustomerSupplierSkeleton <CustomerSupplierSkeleton