refactor(FE): Make depletion and egg fields optional

This commit is contained in:
rstubryan
2026-01-19 17:52:19 +07:00
parent 8a84542c60
commit b1981867ff
3 changed files with 56 additions and 109 deletions
@@ -33,16 +33,16 @@ type RecordingGrowingFormSchemaType = {
qty: number | string; qty: number | string;
}[]; }[];
depletions: { depletions: {
product_warehouse_id: number; product_warehouse_id?: number;
qty: number | string; qty?: number | string;
}[]; }[];
}; };
type RecordingLayingFormSchemaType = RecordingGrowingFormSchemaType & { type RecordingLayingFormSchemaType = RecordingGrowingFormSchemaType & {
eggs: { eggs: {
product_warehouse_id: number; product_warehouse_id?: number;
qty: number | string; qty?: number | string;
weight: number | string; weight?: number | string;
}[]; }[];
}; };
@@ -52,14 +52,14 @@ export type StockSchema = {
}; };
export type DepletionSchema = { export type DepletionSchema = {
product_warehouse_id: number; product_warehouse_id?: number;
qty: number | string; qty?: number | string;
}; };
export type EggSchema = { export type EggSchema = {
product_warehouse_id: number; product_warehouse_id?: number;
qty: number | string; qty?: number | string;
weight: number | string; weight?: number | string;
}; };
const StockObjectSchema: Yup.ObjectSchema<StockSchema> = Yup.object({ const StockObjectSchema: Yup.ObjectSchema<StockSchema> = Yup.object({
@@ -75,28 +75,19 @@ const StockObjectSchema: Yup.ObjectSchema<StockSchema> = Yup.object({
const DepletionObjectSchema: Yup.ObjectSchema<DepletionSchema> = Yup.object({ const DepletionObjectSchema: Yup.ObjectSchema<DepletionSchema> = Yup.object({
product_warehouse_id: Yup.number() product_warehouse_id: Yup.number()
.required('Produk depletions wajib diisi!') .optional()
.min(1, 'Produk depletions wajib diisi!') .typeError('Depletions harus berupa angka!'),
.typeError('Produk depletions harus berupa angka!'),
qty: Yup.number() qty: Yup.number()
.required('Jumlah depletions wajib diisi!') .optional()
.min(1, 'Jumlah depletions minimal 1!')
.typeError('Jumlah depletions harus berupa angka!'), .typeError('Jumlah depletions harus berupa angka!'),
}); });
const EggObjectSchema: Yup.ObjectSchema<EggSchema> = Yup.object({ const EggObjectSchema: Yup.ObjectSchema<EggSchema> = Yup.object({
product_warehouse_id: Yup.number() product_warehouse_id: Yup.number()
.required('Kondisi telur wajib diisi!') .optional()
.min(1, 'Kondisi telur wajib diisi!')
.typeError('Kondisi telur harus berupa angka!'), .typeError('Kondisi telur harus berupa angka!'),
qty: Yup.number() qty: Yup.number().optional().typeError('Jumlah telur harus berupa angka!'),
.required('Jumlah telur wajib diisi!') weight: Yup.number().optional().typeError('Berat telur harus berupa angka!'),
.min(1, 'Jumlah telur tidak boleh 0!')
.typeError('Jumlah telur harus berupa angka!'),
weight: Yup.number()
.required('Berat telur wajib diisi!')
.min(1, 'Berat telur minimal 1 gram!')
.typeError('Berat telur harus berupa angka!'),
}); });
export const RecordingGrowingFormSchema: Yup.ObjectSchema<RecordingGrowingFormSchemaType> = export const RecordingGrowingFormSchema: Yup.ObjectSchema<RecordingGrowingFormSchemaType> =
@@ -163,18 +154,12 @@ export const RecordingGrowingFormSchema: Yup.ObjectSchema<RecordingGrowingFormSc
.of(StockObjectSchema) .of(StockObjectSchema)
.min(1, 'Minimal harus ada 1 data stok!') .min(1, 'Minimal harus ada 1 data stok!')
.required('Data stok wajib diisi!'), .required('Data stok wajib diisi!'),
depletions: Yup.array() depletions: Yup.array().of(DepletionObjectSchema).default([]),
.of(DepletionObjectSchema)
.min(1, 'Minimal harus ada 1 data depletions!')
.required('Data depletions wajib diisi!'),
}); });
export const RecordingLayingFormSchema: Yup.ObjectSchema<RecordingLayingFormSchemaType> = export const RecordingLayingFormSchema: Yup.ObjectSchema<RecordingLayingFormSchemaType> =
RecordingGrowingFormSchema.shape({ RecordingGrowingFormSchema.shape({
eggs: Yup.array() eggs: Yup.array().of(EggObjectSchema).default([]),
.of(EggObjectSchema)
.min(1, 'Minimal harus ada 1 data telur!')
.required('Data telur wajib diisi!'),
}); });
export const UpdateRecordingGrowingFormSchema = export const UpdateRecordingGrowingFormSchema =
@@ -309,6 +309,13 @@ const RecordingForm = ({ type = 'add', initialValues }: RecordingFormProps) => {
// ===== PAYLOAD CREATION HELPERS ===== // ===== PAYLOAD CREATION HELPERS =====
const createGrowingPayload = useCallback( const createGrowingPayload = useCallback(
(values: RecordingGrowingFormValues) => { (values: RecordingGrowingFormValues) => {
const depletions = values.depletions
?.filter((d) => d.product_warehouse_id && d.qty)
.map((depletion) => ({
product_warehouse_id: depletion.product_warehouse_id!,
qty: Number(depletion.qty) || 0,
}));
return { return {
project_flock_kandang_id: values.project_flock_kandang_id, project_flock_kandang_id: values.project_flock_kandang_id,
record_date: values.record_date, record_date: values.record_date,
@@ -316,10 +323,7 @@ const RecordingForm = ({ type = 'add', initialValues }: RecordingFormProps) => {
product_warehouse_id: stock.product_warehouse_id, product_warehouse_id: stock.product_warehouse_id,
qty: Number(stock.qty) || 0, qty: Number(stock.qty) || 0,
})), })),
depletions: (values.depletions ?? []).map((depletion) => ({ ...(depletions && depletions.length > 0 && { depletions }),
product_warehouse_id: depletion.product_warehouse_id,
qty: Number(depletion.qty) || 0,
})),
}; };
}, },
[] []
@@ -327,25 +331,33 @@ const RecordingForm = ({ type = 'add', initialValues }: RecordingFormProps) => {
const createLayingPayload = useCallback( const createLayingPayload = useCallback(
(values: RecordingLayingFormValues) => { (values: RecordingLayingFormValues) => {
return { const depletions = values.depletions
project_flock_kandang_id: values.project_flock_kandang_id, ?.filter((d) => d.product_warehouse_id && d.qty)
record_date: values.record_date, .map((depletion) => ({
stocks: (values.stocks ?? []).map((stock) => ({ product_warehouse_id: depletion.product_warehouse_id!,
product_warehouse_id: stock.product_warehouse_id,
qty: Number(stock.qty) || 0,
})),
depletions: (values.depletions ?? []).map((depletion) => ({
product_warehouse_id: depletion.product_warehouse_id,
qty: Number(depletion.qty) || 0, qty: Number(depletion.qty) || 0,
})), }));
eggs: (values.eggs ?? []).map((egg) => ({
product_warehouse_id: egg.product_warehouse_id, const eggs = values.eggs
?.filter((e) => e.product_warehouse_id && e.qty && e.weight)
.map((egg) => ({
product_warehouse_id: egg.product_warehouse_id!,
qty: Number(egg.qty) || 0, qty: Number(egg.qty) || 0,
weight: weight:
typeof egg.weight === 'number' typeof egg.weight === 'number'
? egg.weight ? egg.weight
: parseFloat(String(egg.weight)) || 0, : parseFloat(String(egg.weight)) || 0,
}));
return {
project_flock_kandang_id: values.project_flock_kandang_id,
record_date: values.record_date,
stocks: values.stocks.map((stock) => ({
product_warehouse_id: stock.product_warehouse_id,
qty: Number(stock.qty) || 0,
})), })),
...(depletions && depletions.length > 0 && { depletions }),
...(eggs && eggs.length > 0 && { eggs }),
}; };
}, },
[] []
@@ -1692,12 +1704,6 @@ const RecordingForm = ({ type = 'add', initialValues }: RecordingFormProps) => {
<AlertErrorList formErrorList={formErrorList} onClose={close} /> <AlertErrorList formErrorList={formErrorList} onClose={close} />
)} )}
<div className='text-xs text-error'>
{JSON.stringify(formik.errors)}
</div>
<div className='text-xs text-success'>
{JSON.stringify(formik.values)}
</div>
{/* Basic Info Card */} {/* Basic Info Card */}
{(type === 'add' || type === 'edit') && ( {(type === 'add' || type === 'edit') && (
<Card <Card
@@ -2557,24 +2563,8 @@ const RecordingForm = ({ type = 'add', initialValues }: RecordingFormProps) => {
/> />
</th> </th>
)} )}
<th> <th>Kondisi</th>
Kondisi <th>Jumlah</th>
<span
className='tooltip tooltip-error tooltip-bottom '
data-tip='required'
>
<span className='text-error'>*</span>
</span>
</th>
<th>
Jumlah
<span
className='tooltip tooltip-error tooltip-bottom '
data-tip='required'
>
<span className='text-error'>*</span>
</span>
</th>
{(type as 'add' | 'edit' | 'detail') !== 'detail' && ( {(type as 'add' | 'edit' | 'detail') !== 'detail' && (
<th>Action</th> <th>Action</th>
)} )}
@@ -2652,7 +2642,6 @@ const RecordingForm = ({ type = 'add', initialValues }: RecordingFormProps) => {
</td> </td>
<td> <td>
<NumberInput <NumberInput
required
name={`depletions.${idx}.qty`} name={`depletions.${idx}.qty`}
value={depletion.qty ?? ''} value={depletion.qty ?? ''}
onChange={handleDepletionQtyChangeWrapper(idx)} onChange={handleDepletionQtyChangeWrapper(idx)}
@@ -2768,33 +2757,9 @@ const RecordingForm = ({ type = 'add', initialValues }: RecordingFormProps) => {
/> />
</th> </th>
)} )}
<th> <th>Kondisi Telur</th>
Kondisi Telur <th>Jumlah</th>
<span <th>Berat (gram)</th>
className='tooltip tooltip-error tooltip-bottom '
data-tip='required'
>
<span className='text-error'>*</span>
</span>
</th>
<th>
Jumlah
<span
className='tooltip tooltip-error tooltip-bottom '
data-tip='required'
>
<span className='text-error'>*</span>
</span>
</th>
<th>
Berat (gram)
<span
className='tooltip tooltip-error tooltip-bottom '
data-tip='required'
>
<span className='text-error'>*</span>
</span>
</th>
{(type as 'add' | 'edit' | 'detail') !== 'detail' && ( {(type as 'add' | 'edit' | 'detail') !== 'detail' && (
<th>Action</th> <th>Action</th>
)} )}
@@ -2829,7 +2794,6 @@ const RecordingForm = ({ type = 'add', initialValues }: RecordingFormProps) => {
)} )}
<td> <td>
<SelectInput <SelectInput
required
value={ value={
eggProducts.find( eggProducts.find(
(product) => (product) =>
@@ -2872,7 +2836,6 @@ const RecordingForm = ({ type = 'add', initialValues }: RecordingFormProps) => {
</td> </td>
<td> <td>
<NumberInput <NumberInput
required
name={`eggs.${idx}.qty`} name={`eggs.${idx}.qty`}
value={egg.qty ?? ''} value={egg.qty ?? ''}
onChange={handleEggQtyChangeWrapper(idx)} onChange={handleEggQtyChangeWrapper(idx)}
@@ -2897,7 +2860,6 @@ const RecordingForm = ({ type = 'add', initialValues }: RecordingFormProps) => {
</td> </td>
<td> <td>
<NumberInput <NumberInput
required
name={`eggs.${idx}.weight`} name={`eggs.${idx}.weight`}
value={egg.weight ?? ''} value={egg.weight ?? ''}
onChange={handleEggWeightChangeWrapper(idx)} onChange={handleEggWeightChangeWrapper(idx)}
+5 -5
View File
@@ -111,15 +111,15 @@ export type CreateGrowingRecordingPayload = {
qty: number; qty: number;
}[]; }[];
depletions?: { depletions?: {
product_warehouse_id: number; product_warehouse_id?: number;
qty: number; qty?: number;
}[]; }[];
}; };
export type CreateEggPayload = { export type CreateEggPayload = {
product_warehouse_id: number; product_warehouse_id?: number;
qty: number; qty?: number;
weight: number; weight?: number;
}; };
export type CreateLayingRecordingPayload = CreateGrowingRecordingPayload & { export type CreateLayingRecordingPayload = CreateGrowingRecordingPayload & {