From 9562ce7b40deebc7d9ce3b0b6c2dcff98136f37d Mon Sep 17 00:00:00 2001
From: randy-ar <randyabdulrahman87@gmail.com>
Date: Fri, 2 Jan 2026 15:11:06 +0700
Subject: [PATCH] fix(FE): remove bypass permission in marketing detail and
 form page

---
 .../marketing/detail/MarketingDetail.tsx      | 72 +++----------------
 .../pages/marketing/form/MarketingForm.tsx    | 19 +----
 .../sales-order/SalesOrderProductForm.tsx     |  5 +-
 .../table-view/DeliveryOrderProductTable.tsx  | 60 ----------------
 4 files changed, 13 insertions(+), 143 deletions(-)

diff --git a/src/components/pages/marketing/detail/MarketingDetail.tsx b/src/components/pages/marketing/detail/MarketingDetail.tsx
index 4c9f1a34..677ea422 100644
--- a/src/components/pages/marketing/detail/MarketingDetail.tsx
+++ b/src/components/pages/marketing/detail/MarketingDetail.tsx
@@ -77,10 +77,6 @@ const MarketingDetail = ({
     confirmationModal.openModal();
   };
 
-  const deliveryClickHandler = () => {
-    deliveryModal.openModal();
-  };
-
   const deleteClickHandler = () => {
     deleteModal.openModal();
   };
@@ -135,7 +131,7 @@ const MarketingDetail = ({
         <div className='flex-row flex gap-3'>
           {initialValues?.latest_approval?.step_number == 1 && (
             <>
-              {/* <RequirePermission permissions='lti.marketing.sales_order.approve'>
+              <RequirePermission permissions='lti.marketing.sales_order.approve'>
                 <Button
                   color='success'
                   onClick={approveClickHandler}
@@ -147,20 +143,9 @@ const MarketingDetail = ({
                   <Icon icon='mdi:check' width={24} height={24} />
                   Approve
                 </Button>
-              </RequirePermission> */}
-              <Button
-                color='success'
-                onClick={approveClickHandler}
-                disabled={
-                  initialValues?.latest_approval?.step_number == 1 &&
-                  initialValues?.latest_approval?.action == 'REJECTED'
-                }
-              >
-                <Icon icon='mdi:check' width={24} height={24} />
-                Approve
-              </Button>
+              </RequirePermission>
 
-              {/* <RequirePermission permissions='lti.marketing.sales_order.approve'>
+              <RequirePermission permissions='lti.marketing.sales_order.approve'>
                 <Button
                   color='error'
                   onClick={rejectClickHandler}
@@ -172,23 +157,12 @@ const MarketingDetail = ({
                   <Icon icon='mdi:close' width={24} height={24} />
                   Reject
                 </Button>
-              </RequirePermission> */}
-              <Button
-                color='error'
-                onClick={rejectClickHandler}
-                disabled={
-                  initialValues?.latest_approval?.step_number == 1 &&
-                  initialValues?.latest_approval?.action == 'REJECTED'
-                }
-              >
-                <Icon icon='mdi:close' width={24} height={24} />
-                Reject
-              </Button>
+              </RequirePermission>
             </>
           )}
           {initialValues?.latest_approval?.step_number != 1 && (
             <>
-              {/* <RequirePermission
+              <RequirePermission
                 permissions={
                   initialValues?.latest_approval?.step_number == 3
                     ? 'lti.marketing.delivery_order.update'
@@ -209,21 +183,7 @@ const MarketingDetail = ({
                     : 'Tambah '}
                   Delivery Order
                 </Button>
-              </RequirePermission> */}
-              <Button
-                color='success'
-                href={
-                  initialValues?.latest_approval?.step_number == 3
-                    ? `/marketing/detail/delivery-orders/edit?marketingId=${initialValues?.id}`
-                    : `/marketing/add/delivery-orders?marketingId=${initialValues?.id}`
-                }
-              >
-                <Icon icon='mdi:truck' width={24} height={24} />
-                {initialValues?.latest_approval?.step_number == 3
-                  ? 'Edit '
-                  : 'Tambah '}
-                Delivery Order
-              </Button>
+              </RequirePermission>
             </>
           )}
         </div>
@@ -466,7 +426,7 @@ const MarketingDetail = ({
         <div className='flex flex-row gap-3'>
           {initialValues?.latest_approval?.step_number != 3 && (
             <>
-              {/* <RequirePermission permissions='lti.marketing.sales_order.update'>
+              <RequirePermission permissions='lti.marketing.sales_order.update'>
                 <Button
                   color='warning'
                   type='button'
@@ -475,27 +435,15 @@ const MarketingDetail = ({
                   <Icon icon='mdi:pencil' width={24} height={24} />
                   Edit
                 </Button>
-              </RequirePermission> */}
-              <Button
-                color='warning'
-                type='button'
-                href={`/marketing/detail/${initialValues?.latest_approval?.step_number == 3 ? 'delivery-orders' : 'sales-orders'}/edit?marketingId=${initialValues?.id}`}
-              >
-                <Icon icon='mdi:pencil' width={24} height={24} />
-                Edit
-              </Button>
+              </RequirePermission>
             </>
           )}
-          {/* <RequirePermission permissions='lti.marketing.sales_order.delete'>
+          <RequirePermission permissions='lti.marketing.sales_order.delete'>
             <Button color='error' onClick={deleteClickHandler}>
               <Icon icon='mdi:delete' width={24} height={24} />
               Hapus
             </Button>
-          </RequirePermission> */}
-          <Button color='error' onClick={deleteClickHandler}>
-            <Icon icon='mdi:delete' width={24} height={24} />
-            Hapus
-          </Button>
+          </RequirePermission>
         </div>
       </div>
       <ConfirmationModal
diff --git a/src/components/pages/marketing/form/MarketingForm.tsx b/src/components/pages/marketing/form/MarketingForm.tsx
index ccbba2b5..1c5322e1 100644
--- a/src/components/pages/marketing/form/MarketingForm.tsx
+++ b/src/components/pages/marketing/form/MarketingForm.tsx
@@ -635,12 +635,6 @@ const MarketingForm = ({
                 wrapper: 'bg-white w-full',
               }}
             >
-              {/* <div className='text-blue-500'>
-                {JSON.stringify(formik.values)}
-              </div>
-              <div className='text-red-500'>
-                {JSON.stringify(formik.errors)}
-              </div> */}
               <MemoizedDeliveryOrderProductTable
                 formType={formType}
                 data={deliveryOrderValues}
@@ -690,7 +684,7 @@ const MarketingForm = ({
       {/* Actions button */}
       {formType == 'edit' && (
         <div className='flex flex-row justify-start'>
-          {/* <RequirePermission permissions='lti.marketing.sales_order.delete'>
+          <RequirePermission permissions='lti.marketing.sales_order.delete'>
             <Button
               type='button'
               color='error'
@@ -700,16 +694,7 @@ const MarketingForm = ({
               <Icon icon='mdi:trash' width={24} height={24} />
               Hapus
             </Button>
-          </RequirePermission> */}
-          <Button
-            type='button'
-            color='error'
-            onClick={handleDelete}
-            isLoading={isLoading}
-          >
-            <Icon icon='mdi:trash' width={24} height={24} />
-            Hapus
-          </Button>
+          </RequirePermission>
         </div>
       )}
 
diff --git a/src/components/pages/marketing/form/repeater/sales-order/SalesOrderProductForm.tsx b/src/components/pages/marketing/form/repeater/sales-order/SalesOrderProductForm.tsx
index 75aa3ba6..aa9dd9e8 100644
--- a/src/components/pages/marketing/form/repeater/sales-order/SalesOrderProductForm.tsx
+++ b/src/components/pages/marketing/form/repeater/sales-order/SalesOrderProductForm.tsx
@@ -11,7 +11,7 @@ import SelectInput, {
   useSelect,
 } from '@/components/input/SelectInput';
 import { Kandang } from '@/types/api/master-data/kandang';
-import { KandangApi, WarehouseApi } from '@/services/api/master-data';
+import { WarehouseApi } from '@/services/api/master-data';
 import { ProductWarehouse } from '@/types/api/inventory/product-warehouse';
 import { ProductWarehouseApi } from '@/services/api/inventory';
 import NumberInput from '@/components/input/NumberInput';
@@ -180,9 +180,6 @@ const SalesOrderProductForm = ({
             </Alert>
           </div>
         )}
-        {/* <small className='block text-rose-500'>
-          {JSON.stringify(formik.errors)}
-        </small> */}
         <div className='grid sm:grid-cols-2 gap-4 z-200'>
           <PatternInput
             name='vehicle_number'
diff --git a/src/components/pages/marketing/form/table-view/DeliveryOrderProductTable.tsx b/src/components/pages/marketing/form/table-view/DeliveryOrderProductTable.tsx
index c67b1a3c..ac59529e 100644
--- a/src/components/pages/marketing/form/table-view/DeliveryOrderProductTable.tsx
+++ b/src/components/pages/marketing/form/table-view/DeliveryOrderProductTable.tsx
@@ -32,38 +32,6 @@ const DeliveryOrderProductTable = ({
 
   const columns = useMemo(() => {
     const cols = [
-      // {
-      //   id: 'select',
-      //   header: ({
-      //     table,
-      //   }: {
-      //     table: TanStack.Table<DeliveryOrderProductFormValues>;
-      //   }) => (
-      //     <div className='w-full flex flex-row justify-center'>
-      //       <CheckboxInput
-      //         name='allRow'
-      //         checked={table.getIsAllRowsSelected()}
-      //         indeterminate={table.getIsSomeRowsSelected()}
-      //         onChange={table.getToggleAllRowsSelectedHandler()}
-      //       />
-      //     </div>
-      //   ),
-      //   cell: ({
-      //     row,
-      //   }: {
-      //     row: TanStack.Row<DeliveryOrderProductFormValues>;
-      //   }) => (
-      //     <div>
-      //       <CheckboxInput
-      //         name='row'
-      //         checked={row.getIsSelected()}
-      //         disabled={!row.getCanSelect()}
-      //         indeterminate={row.getIsSomeSelected()}
-      //         onChange={row.getToggleSelectedHandler()}
-      //       />
-      //     </div>
-      //   ),
-      // },
       {
         accessorFn: (row: DeliveryOrderProductFormValues) => row.do_number,
         header: 'No. Pengiriman',
@@ -188,18 +156,6 @@ const DeliveryOrderProductTable = ({
                 </Button>
               )}
               {!props.row.original.qty && '-'}
-              {/* {formType == 'add_deliver' && (
-                <Button
-                  color='error'
-                  className='p-1'
-                  onClick={() =>
-                    onDeleteRef.current(props.row.original.id as number)
-                  }
-                  type='button'
-                >
-                  <Icon icon='mdi:trash' width={16} height={16} />
-                </Button>
-              )} */}
             </>
           </div>
         ),
@@ -248,22 +204,6 @@ const DeliveryOrderProductTable = ({
           <Icon icon='mdi:plus' width={16} height={16} />
           Tambah Pengiriman
         </Button>
-        {/* {selectedRowIds.length > 0 && (
-          <Button
-            type='button'
-            variant='outline'
-            color='error'
-            className='justify-start w-fit py-1 text-sm'
-            onClick={onBulkDelete}
-          >
-            <Icon icon='mdi:trash' width={16} height={16} />
-            Hapus
-            {selectedRowIds.length > 0
-              ? ` (${selectedRowIds.length})`
-              : ''}{' '}
-            Pengiriman
-          </Button>
-        )} */}
       </div>
     </>
   );