From 8e80d668fa178ceda849879ab67d334b5f4a186b Mon Sep 17 00:00:00 2001
From: rstubryan <restubumirr@gmail.com>
Date: Tue, 9 Dec 2025 10:13:48 +0700
Subject: [PATCH] refactor(FE-311): Remove credit_term from purchase request
 data and UI

---
 .../request/PurchaseRequestForm.schema.ts     |  6 --
 .../form/request/PurchaseRequestForm.tsx      | 79 +------------------
 .../purchase/order/PurchaseOrderInvoice.tsx   |  3 -
 src/types/api/purchase/purchase.d.ts          |  2 -
 4 files changed, 2 insertions(+), 88 deletions(-)

diff --git a/src/components/pages/purchase/form/request/PurchaseRequestForm.schema.ts b/src/components/pages/purchase/form/request/PurchaseRequestForm.schema.ts
index 414371c3..05167715 100644
--- a/src/components/pages/purchase/form/request/PurchaseRequestForm.schema.ts
+++ b/src/components/pages/purchase/form/request/PurchaseRequestForm.schema.ts
@@ -7,7 +7,6 @@ type PurchaseRequestFormSchemaType = {
     label: string;
   } | null;
   supplier_id: number;
-  credit_term: number;
   area?: {
     value: number;
     label: string;
@@ -78,10 +77,6 @@ export const PurchaseRequestFormSchema: Yup.ObjectSchema<PurchaseRequestFormSche
       value: Yup.number().min(1).required(),
       label: Yup.string().required(),
     }).nullable(),
-    credit_term: Yup.number()
-      .required('Jangka waktu kredit wajib diisi!')
-      .min(0, 'Jangka waktu kredit tidak boleh kurang dari 0!')
-      .typeError('Jangka waktu kredit wajib diisi!'),
     supplier_id: Yup.number()
       .required('Supplier wajib dipilih!')
       .min(1, 'Supplier wajib dipilih!')
@@ -124,7 +119,6 @@ export const getPurchaseRequestFormInitialValues = (
       }
     : null,
   supplier_id: initialValues?.supplier?.id ?? 0,
-  credit_term: initialValues?.credit_term ?? 0,
   area: initialValues?.area
     ? {
         value: initialValues.area.id,
diff --git a/src/components/pages/purchase/form/request/PurchaseRequestForm.tsx b/src/components/pages/purchase/form/request/PurchaseRequestForm.tsx
index 396ce7bb..e532ad2a 100644
--- a/src/components/pages/purchase/form/request/PurchaseRequestForm.tsx
+++ b/src/components/pages/purchase/form/request/PurchaseRequestForm.tsx
@@ -185,10 +185,6 @@ const PurchaseRequestForm = ({
           typeof values.supplier_id === 'string'
             ? parseInt(values.supplier_id) || 0
             : values.supplier_id || 0,
-        credit_term:
-          typeof values.credit_term === 'string'
-            ? parseInt(values.credit_term) || 0
-            : values.credit_term || 0,
         notes: values.notes || '',
         items: (values.items || []).map((item) => ({
           warehouse_id: Number(item.warehouse_id) || 0,
@@ -342,27 +338,6 @@ const PurchaseRequestForm = ({
   };
 
   // ===== UTILITY FUNCTIONS =====
-  const updateCreditTermBasedOnSupplier = useCallback(
-    (supplierId: number) => {
-      if (supplierId > 0 && isResponseSuccess(supplierRawData)) {
-        const supplierData = supplierRawData.data.find(
-          (s: Supplier) => s.id === supplierId
-        );
-        if (supplierData?.due_date) {
-          formik.setFieldTouched('credit_term', false);
-          formik.setFieldValue('credit_term', supplierData.due_date.toString());
-        } else {
-          formik.setFieldTouched('credit_term', false);
-          formik.setFieldValue('credit_term', '');
-        }
-      } else {
-        formik.setFieldTouched('credit_term', false);
-        formik.setFieldValue('credit_term', '');
-      }
-    },
-    [supplierRawData]
-  );
-
   const resetPurchaseItems = useCallback(() => {
     if (formik.values.items) {
       formik.values.items.forEach((_, idx) => {
@@ -377,16 +352,6 @@ const PurchaseRequestForm = ({
   }, []);
 
   // ===== SIDE EFFECTS =====
-  useEffect(() => {
-    if (formik.values.supplier_id && Number(formik.values.supplier_id) > 0) {
-      updateCreditTermBasedOnSupplier(Number(formik.values.supplier_id));
-      resetPurchaseItems();
-    } else {
-      formik.setFieldTouched('credit_term', false);
-      formik.setFieldValue('credit_term', '');
-      resetPurchaseItems();
-    }
-  }, [formik.values.supplier_id]);
 
   // ===== FORM HANDLERS =====
   const handleSupplierChange = useCallback(
@@ -402,23 +367,6 @@ const PurchaseRequestForm = ({
     []
   );
 
-  const handleCreditTermChange = useCallback(
-    (e: React.ChangeEvent<HTMLInputElement>) => {
-      const value = e.target.value;
-
-      formik.setFieldTouched('credit_term', true);
-      formik.setFieldValue('credit_term', value);
-    },
-    []
-  );
-
-  const handleCreditTermBlur = useCallback(
-    (e: React.FocusEvent<HTMLInputElement>) => {
-      formik.handleBlur(e);
-    },
-    [formik]
-  );
-
   const handleAreaChange = useCallback(
     (val: OptionType | OptionType[] | null) => {
       const area = val as OptionType | null;
@@ -499,7 +447,7 @@ const PurchaseRequestForm = ({
               body: 'flex flex-col gap-6',
             }}
           >
-            <div className={'grid grid-cols-1 md:grid-cols-2 gap-6'}>
+            <div className={'grid grid-cols-1 md:grid-cols-3 gap-6'}>
               <SelectInput
                 required
                 label='Vendor'
@@ -518,29 +466,6 @@ const PurchaseRequestForm = ({
                 isClearable
               />
 
-              <NumberInput
-                required={!!formik.values.supplier_id}
-                label='Jatuh tempo (hari)'
-                name='credit_term'
-                value={formik.values.credit_term || ''}
-                onChange={handleCreditTermChange}
-                onBlur={handleCreditTermBlur}
-                isError={
-                  formik.touched.credit_term &&
-                  Boolean(formik.errors.credit_term)
-                }
-                errorMessage={formik.errors.credit_term as string}
-                readOnly={type === 'detail' || !formik.values.supplier_id}
-                disabled={type === 'detail' || !formik.values.supplier_id}
-                allowNegative={false}
-                decimalScale={0}
-                placeholder={
-                  !formik.values.supplier_id
-                    ? 'Pilih Vendor terlebih dahulu'
-                    : 'Masukkan jumlah hari jatuh tempo'
-                }
-              />
-
               <SelectInput
                 label='Area'
                 placeholder='Pilih Area...'
@@ -565,7 +490,7 @@ const PurchaseRequestForm = ({
                 isClearable={type !== 'detail'}
               />
 
-              <div className={'col-span-2'}>
+              <div className={'md:col-span-3'}>
                 <TextInput
                   label='Notes'
                   name='notes'
diff --git a/src/components/pages/purchase/order/PurchaseOrderInvoice.tsx b/src/components/pages/purchase/order/PurchaseOrderInvoice.tsx
index 36aea9c7..3ee48623 100644
--- a/src/components/pages/purchase/order/PurchaseOrderInvoice.tsx
+++ b/src/components/pages/purchase/order/PurchaseOrderInvoice.tsx
@@ -309,9 +309,6 @@ const PurchaseOrderInvoice = ({ data }: PurchaseOrderInvoiceProps) => {
                     {purchaseData?.supplier?.alias || ''})
                   </Text>
                   <Text>{purchaseData?.supplier?.category || '-'}</Text>
-                  <Text>
-                    Credit Term: {purchaseData?.credit_term || 0} hari
-                  </Text>
                   <Text>
                     Due Date:{' '}
                     {purchaseData?.due_date
diff --git a/src/types/api/purchase/purchase.d.ts b/src/types/api/purchase/purchase.d.ts
index 50221bfa..e596187a 100644
--- a/src/types/api/purchase/purchase.d.ts
+++ b/src/types/api/purchase/purchase.d.ts
@@ -51,7 +51,6 @@ export type BasePurchase = {
   po_document_path?: string | null;
   po_date: string;
   supplier: Supplier;
-  credit_term?: number;
   due_date: string;
   notes?: string | null;
   deleted_at?: string | null;
@@ -67,7 +66,6 @@ export type Purchase = BaseMetadata & BasePurchase;
 
 export type CreatePurchaseRequestPayload = {
   supplier_id: number;
-  credit_term: number;
   notes?: string | null;
   items: {
     warehouse_id: number;