From 633deece21eece881d379d6d949a74d6192a8aff Mon Sep 17 00:00:00 2001 From: rstubryan Date: Fri, 6 Mar 2026 14:05:11 +0700 Subject: [PATCH] refactor(FE): Fix dependency array in ExpenseRealizationForm useCallback --- src/components/pages/expense/form/ExpenseRealizationForm.tsx | 2 +- src/components/pages/expense/form/ExpenseRequestForm.tsx | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/components/pages/expense/form/ExpenseRealizationForm.tsx b/src/components/pages/expense/form/ExpenseRealizationForm.tsx index e9720d0b..54f2e759 100644 --- a/src/components/pages/expense/form/ExpenseRealizationForm.tsx +++ b/src/components/pages/expense/form/ExpenseRealizationForm.tsx @@ -66,7 +66,7 @@ const ExpenseRealizationForm = ({ toast.success(createExpenseRes?.message as string); router.push('/expense'); }, - [router] + [router, initialValues?.id] ); const updateExpenseHandler = useCallback( diff --git a/src/components/pages/expense/form/ExpenseRequestForm.tsx b/src/components/pages/expense/form/ExpenseRequestForm.tsx index adc825c2..fcc66847 100644 --- a/src/components/pages/expense/form/ExpenseRequestForm.tsx +++ b/src/components/pages/expense/form/ExpenseRequestForm.tsx @@ -178,12 +178,14 @@ const ExpenseRequestForm = ({ setInputValue: setLocationInputValue, options: locationOptions, isLoadingOptions: isLoadingLocationOptions, + loadMore: loadMoreLocationOptions, } = useSelect(LocationApi.basePath, 'id', 'name'); const { setInputValue: setVendorInputValue, options: supplierOptions, isLoadingOptions: isLoadingVendorOptions, + loadMore: loadMoreVendorOptions, } = useSelect(SupplierApi.basePath, 'id', 'name'); const categoryChangeHandler = (val: OptionType | OptionType[] | null) => { @@ -414,6 +416,7 @@ const ExpenseRequestForm = ({ errorMessage={formik.errors.location_id as string} isClearable className={{ wrapper: 'col-span-12 sm:col-span-4' }} + onMenuScrollToBottom={loadMoreLocationOptions} />