refactor(FE): Remove redundant transformations and validations in

schemas
This commit is contained in:
rstubryan
2026-02-23 16:05:12 +07:00
parent 35b09b514f
commit 50424a25fc
2 changed files with 1 additions and 33 deletions
@@ -44,29 +44,13 @@ export const DeliveryOrderProductSchema: Yup.ObjectSchema<DeliveryOrderProductSc
.min(1, 'Harga Satuan wajib diisi!') .min(1, 'Harga Satuan wajib diisi!')
.required('Harga Satuan wajib diisi!'), .required('Harga Satuan wajib diisi!'),
total_weight: Yup.number() total_weight: Yup.number()
.transform((value) =>
value === '' || value === null ? 0 : Number(value)
)
.min(0, 'Total Bobot wajib diisi!') .min(0, 'Total Bobot wajib diisi!')
.test(
'is-greater-than-zero',
'Total Bobot harus lebih dari 0!',
(value) => value !== undefined && value > 0
)
.required('Total Bobot wajib diisi!'), .required('Total Bobot wajib diisi!'),
qty: Yup.number() qty: Yup.number()
.min(1, 'Kuantitas wajib diisi!') .min(1, 'Kuantitas wajib diisi!')
.required('Kuantitas wajib diisi!'), .required('Kuantitas wajib diisi!'),
avg_weight: Yup.number() avg_weight: Yup.number()
.transform((value) =>
value === '' || value === null ? 0 : Number(value)
)
.min(0, 'Avg. Bobot wajib diisi!') .min(0, 'Avg. Bobot wajib diisi!')
.test(
'is-greater-than-zero',
'Avg. Bobot harus lebih dari 0!',
(value) => value !== undefined && value > 0
)
.required('Avg. Bobot wajib diisi!'), .required('Avg. Bobot wajib diisi!'),
total_price: Yup.number() total_price: Yup.number()
.min(1, 'Total Penjualan wajib diisi!') .min(1, 'Total Penjualan wajib diisi!')
@@ -70,29 +70,13 @@ export const SalesOrderProductSchema: Yup.ObjectSchema<SalesOrderProductSchemaTy
.min(1, 'Harga Satuan wajib diisi!') .min(1, 'Harga Satuan wajib diisi!')
.required('Harga Satuan wajib diisi!'), .required('Harga Satuan wajib diisi!'),
total_weight: Yup.number() total_weight: Yup.number()
.transform((value) => .min(0, 'Total Bobot wajib diisi!')
value === '' || value === null ? 0 : Number(value)
)
.min(0, 'Total Bobot tidak boleh negatif!')
.test(
'is-greater-than-zero',
'Total Bobot harus lebih dari 0!',
(value) => value !== undefined && value > 0
)
.required('Total Bobot wajib diisi!'), .required('Total Bobot wajib diisi!'),
qty: Yup.number() qty: Yup.number()
.min(1, 'Kuantitas wajib diisi!') .min(1, 'Kuantitas wajib diisi!')
.required('Kuantitas wajib diisi!'), .required('Kuantitas wajib diisi!'),
avg_weight: Yup.number() avg_weight: Yup.number()
.transform((value) =>
value === '' || value === null ? 0 : Number(value)
)
.min(0, 'Avg. Bobot wajib diisi!') .min(0, 'Avg. Bobot wajib diisi!')
.test(
'is-greater-than-zero',
'Avg. Bobot harus lebih dari 0!',
(value) => value !== undefined && value > 0
)
.required('Avg. Bobot wajib diisi!'), .required('Avg. Bobot wajib diisi!'),
total_price: Yup.number() total_price: Yup.number()
.min(1, 'Total Penjualan wajib diisi!') .min(1, 'Total Penjualan wajib diisi!')