refactor(FE): Refactor tab actions to use memoized components

This commit is contained in:
rstubryan
2026-03-05 11:59:27 +07:00
parent a7951b6c28
commit 2de6636bbf
3 changed files with 306 additions and 254 deletions
@@ -1,4 +1,4 @@
import { useState, useMemo, useCallback } from 'react'; import { useState, useMemo, useCallback, useRef } from 'react';
import useSWR from 'swr'; import useSWR from 'swr';
import { useSelect } from '@/components/input/SelectInput'; import { useSelect } from '@/components/input/SelectInput';
import DateInput from '@/components/input/DateInput'; import DateInput from '@/components/input/DateInput';
@@ -83,6 +83,8 @@ const DailyMarketingTab = ({ tabId }: DailyMarketingTabProps) => {
const [dateErrorShown, setDateErrorShown] = useState(false); const [dateErrorShown, setDateErrorShown] = useState(false);
const [hasDateError, setHasDateError] = useState(false); const [hasDateError, setHasDateError] = useState(false);
const handleFilterModalOpenRef = useRef(() => {});
const filterModal = useModal(); const filterModal = useModal();
// ===== OPTIONS ===== // ===== OPTIONS =====
@@ -102,11 +104,6 @@ const DailyMarketingTab = ({ tabId }: DailyMarketingTabProps) => {
const { options: customerOptions, isLoadingOptions: isLoadingCustomers } = const { options: customerOptions, isLoadingOptions: isLoadingCustomers } =
useSelect(CustomerApi.basePath, 'id', 'name', 'search'); useSelect(CustomerApi.basePath, 'id', 'name', 'search');
const handleFilterModalOpen = () => {
filterModal.openModal();
formik.validateForm();
};
// ===== FORMIK SETUP ===== // ===== FORMIK SETUP =====
const formik = useFormik<DailyMarketingReportFilterType>({ const formik = useFormik<DailyMarketingReportFilterType>({
initialValues: { initialValues: {
@@ -353,9 +350,13 @@ const DailyMarketingTab = ({ tabId }: DailyMarketingTabProps) => {
} }
}, [dailyMarketingsExport, summaryTotal]); }, [dailyMarketingsExport, summaryTotal]);
// ===== REGISTER TAB ACTIONS TO STORE ===== // ===== TAB ACTIONS COMPONENT =====
const TabActions = useMemo(() => {
return function TabActionsComponent() {
const setTabActions = useTabActionsStore((state) => state.setTabActions); const setTabActions = useTabActionsStore((state) => state.setTabActions);
const clearTabActions = useTabActionsStore((state) => state.clearTabActions); const clearTabActions = useTabActionsStore(
(state) => state.clearTabActions
);
useEffectHook(() => { useEffectHook(() => {
setTabActions( setTabActions(
@@ -367,19 +368,24 @@ const DailyMarketingTab = ({ tabId }: DailyMarketingTabProps) => {
value={searchValue} value={searchValue}
onChange={searchChangeHandler} onChange={searchChangeHandler}
startAdornment={ startAdornment={
<Icon icon='heroicons:magnifying-glass' width={20} height={20} /> <Icon
icon='heroicons:magnifying-glass'
width={20}
height={20}
/>
} }
className={{ className={{
wrapper: 'w-full min-w-48 max-w-3xs', wrapper: 'w-full min-w-48 max-w-3xs',
inputWrapper: 'rounded-xl! shadow-button-soft', inputWrapper: 'rounded-xl! shadow-button-soft',
input: 'placeholder:font-semibold placeholder:text-base-content/50', input:
'placeholder:font-semibold placeholder:text-base-content/50',
}} }}
/> />
<ButtonFilter <ButtonFilter
values={formik.values} values={filterParams}
fieldGroups={[['start_date', 'end_date']]} fieldGroups={[['start_date', 'end_date']]}
onClick={handleFilterModalOpen} onClick={() => handleFilterModalOpenRef.current()}
variant='outline' variant='outline'
className='px-3 py-2.5' className='px-3 py-2.5'
/> />
@@ -409,7 +415,11 @@ const DailyMarketingTab = ({ tabId }: DailyMarketingTabProps) => {
<div className='w-px self-stretch bg-base-content/10' /> <div className='w-px self-stretch bg-base-content/10' />
<Icon icon='heroicons:chevron-down' width={14} height={14} /> <Icon
icon='heroicons:chevron-down'
width={14}
height={14}
/>
</div> </div>
</Button> </Button>
} }
@@ -437,37 +447,29 @@ const DailyMarketingTab = ({ tabId }: DailyMarketingTabProps) => {
</Dropdown> </Dropdown>
</div> </div>
); );
}, [ }, [setTabActions]);
tabId,
searchValue,
formik.values,
isAnyExportLoading,
filterModal.open,
setTabActions,
]);
useEffectHook(() => { useEffectHook(() => {
return () => { return () => {
clearTabActions(tabId); clearTabActions(tabId);
}; };
}, [tabId, clearTabActions]); }, [clearTabActions]);
useEffectHook(() => { return null;
return () => {
if (dateErrorShown) {
toast.dismiss();
}
}; };
}, [dateErrorShown]); }, [
tabId,
filterParams,
searchValue,
isAnyExportLoading,
handleExportExcel,
handleExportPDF,
isExcelExportLoading,
isPdfExportLoading,
searchChangeHandler,
]);
useEffectHook(() => { const TabActionsElement = useMemo(() => <TabActions />, [TabActions]);
return () => {
if (dateErrorShown) {
toast.dismiss();
setDateErrorShown(false);
}
};
}, [filterModal.open, dateErrorShown]);
const getTableColumns = (): ColumnDef<DailyMarketingRow>[] => { const getTableColumns = (): ColumnDef<DailyMarketingRow>[] => {
const tableColumns: ColumnDef<DailyMarketingRow>[] = [ const tableColumns: ColumnDef<DailyMarketingRow>[] = [
@@ -639,6 +641,7 @@ const DailyMarketingTab = ({ tabId }: DailyMarketingTabProps) => {
return ( return (
<> <>
{TabActionsElement}
<div className='w-full p-0 sm:p-3 flex flex-col gap-3'> <div className='w-full p-0 sm:p-3 flex flex-col gap-3'>
{!isSubmitted ? ( {!isSubmitted ? (
<DailyMarketingReportSkeleton <DailyMarketingReportSkeleton
@@ -1,4 +1,4 @@
import { useState, useMemo, useCallback } from 'react'; import { useState, useMemo, useCallback, useRef } from 'react';
import useSWR from 'swr'; import useSWR from 'swr';
import { useSelect } from '@/components/input/SelectInput'; import { useSelect } from '@/components/input/SelectInput';
import DateInput from '@/components/input/DateInput'; import DateInput from '@/components/input/DateInput';
@@ -66,6 +66,8 @@ const HppPerKandangTab = ({ tabId }: HppPerKandangTabProps) => {
// ===== FILTER STATE ===== // ===== FILTER STATE =====
const [filterParams, setFilterParams] = useState<FilterParams>({}); const [filterParams, setFilterParams] = useState<FilterParams>({});
const handleFilterModalOpenRef = useRef(() => {});
const filterModal = useModal(); const filterModal = useModal();
// ===== OPTIONS ===== // ===== OPTIONS =====
@@ -95,11 +97,6 @@ const HppPerKandangTab = ({ tabId }: HppPerKandangTabProps) => {
[] []
); );
const handleFilterModalOpen = () => {
filterModal.openModal();
formik.validateForm();
};
// ===== FORMIK SETUP ===== // ===== FORMIK SETUP =====
const formik = useFormik<HppPerKandangFilterType>({ const formik = useFormik<HppPerKandangFilterType>({
initialValues: { initialValues: {
@@ -140,6 +137,11 @@ const HppPerKandangTab = ({ tabId }: HppPerKandangTabProps) => {
}, },
}); });
handleFilterModalOpenRef.current = () => {
filterModal.openModal();
formik.validateForm();
};
// ===== WEIGHT CHANGE HANDLERS ===== // ===== WEIGHT CHANGE HANDLERS =====
const handleWeightMinChange = useCallback( const handleWeightMinChange = useCallback(
(e: React.ChangeEvent<HTMLInputElement>) => { (e: React.ChangeEvent<HTMLInputElement>) => {
@@ -442,17 +444,21 @@ const HppPerKandangTab = ({ tabId }: HppPerKandangTabProps) => {
allDocSuppliers, allDocSuppliers,
]); ]);
// ===== REGISTER TAB ACTIONS TO STORE ===== // ===== TAB ACTIONS COMPONENT =====
const TabActions = useMemo(() => {
return function TabActionsComponent() {
const setTabActions = useTabActionsStore((state) => state.setTabActions); const setTabActions = useTabActionsStore((state) => state.setTabActions);
const clearTabActions = useTabActionsStore((state) => state.clearTabActions); const clearTabActions = useTabActionsStore(
(state) => state.clearTabActions
);
useEffectHook(() => { useEffectHook(() => {
setTabActions( setTabActions(
tabId, tabId,
<div className='flex flex-row gap-3'> <div className='flex flex-row gap-3'>
<ButtonFilter <ButtonFilter
values={formik.values} values={filterParams}
onClick={handleFilterModalOpen} onClick={() => handleFilterModalOpenRef.current()}
variant='outline' variant='outline'
className='px-3 py-2.5' className='px-3 py-2.5'
/> />
@@ -482,7 +488,11 @@ const HppPerKandangTab = ({ tabId }: HppPerKandangTabProps) => {
<div className='w-px self-stretch bg-base-content/10' /> <div className='w-px self-stretch bg-base-content/10' />
<Icon icon='heroicons:chevron-down' width={14} height={14} /> <Icon
icon='heroicons:chevron-down'
width={14}
height={14}
/>
</div> </div>
</Button> </Button>
} }
@@ -510,19 +520,27 @@ const HppPerKandangTab = ({ tabId }: HppPerKandangTabProps) => {
</Dropdown> </Dropdown>
</div> </div>
); );
}, [ }, [setTabActions]);
tabId,
formik.values,
isAnyExportLoading,
filterModal.open,
setTabActions,
]);
useEffectHook(() => { useEffectHook(() => {
return () => { return () => {
clearTabActions(tabId); clearTabActions(tabId);
}; };
}, [tabId, clearTabActions]); }, [clearTabActions]);
return null;
};
}, [
tabId,
filterParams,
isAnyExportLoading,
handleExportExcel,
handleExportPDF,
isExcelExportLoading,
isPdfExportLoading,
]);
const TabActionsElement = useMemo(() => <TabActions />, [TabActions]);
const getTableColumns = (): ColumnDef<HppPerKandangReport['rows'][0]>[] => { const getTableColumns = (): ColumnDef<HppPerKandangReport['rows'][0]>[] => {
const tableColumns: ColumnDef<HppPerKandangReport['rows'][0]>[] = [ const tableColumns: ColumnDef<HppPerKandangReport['rows'][0]>[] = [
@@ -767,6 +785,7 @@ const HppPerKandangTab = ({ tabId }: HppPerKandangTabProps) => {
return ( return (
<> <>
{TabActionsElement}
<div className='w-full p-0 sm:p-3 flex flex-col gap-3'> <div className='w-full p-0 sm:p-3 flex flex-col gap-3'>
{!isSubmitted ? ( {!isSubmitted ? (
<HppPerKandangSkeleton <HppPerKandangSkeleton
@@ -1,6 +1,12 @@
'use client'; 'use client';
import React, { useState, useCallback, useEffect, useMemo } from 'react'; import React, {
useState,
useCallback,
useEffect,
useMemo,
useRef,
} from 'react';
import useSWR from 'swr'; import useSWR from 'swr';
import { generateProductionResultExcel } from '../export/ProductionResultExportXLSX'; import { generateProductionResultExcel } from '../export/ProductionResultExportXLSX';
import toast from 'react-hot-toast'; import toast from 'react-hot-toast';
@@ -66,6 +72,8 @@ const ProductionResultContent = ({ tabId }: ProductionResultTabProps) => {
const [page, setPage] = useState(1); const [page, setPage] = useState(1);
const [pageSize, setPageSize] = useState(10); const [pageSize, setPageSize] = useState(10);
const handleFilterModalOpenRef = useRef(() => {});
const filterModal = useModal(); const filterModal = useModal();
// ===== TABLE COLUMNS ===== // ===== TABLE COLUMNS =====
@@ -242,6 +250,11 @@ const ProductionResultContent = ({ tabId }: ProductionResultTabProps) => {
}, },
}); });
handleFilterModalOpenRef.current = () => {
filterModal.openModal();
formik.validateForm();
};
// ===== OPTIONS ===== // ===== OPTIONS =====
const { const {
setInputValue: setAreaInputValue, setInputValue: setAreaInputValue,
@@ -519,9 +532,13 @@ const ProductionResultContent = ({ tabId }: ProductionResultTabProps) => {
setIsPdfExportLoading(false); setIsPdfExportLoading(false);
}, [filterParams]); }, [filterParams]);
// ===== REGISTER TAB ACTIONS TO STORE ===== // ===== TAB ACTIONS COMPONENT =====
const TabActions = useMemo(() => {
return function TabActionsComponent() {
const setTabActions = useTabActionsStore((state) => state.setTabActions); const setTabActions = useTabActionsStore((state) => state.setTabActions);
const clearTabActions = useTabActionsStore((state) => state.clearTabActions); const clearTabActions = useTabActionsStore(
(state) => state.clearTabActions
);
useEffect(() => { useEffect(() => {
setTabActions( setTabActions(
@@ -529,7 +546,7 @@ const ProductionResultContent = ({ tabId }: ProductionResultTabProps) => {
<div className='flex flex-row gap-3'> <div className='flex flex-row gap-3'>
<ButtonFilter <ButtonFilter
values={filterParams} values={filterParams}
onClick={() => filterModal.openModal()} onClick={() => handleFilterModalOpenRef.current()}
variant='outline' variant='outline'
className='px-3 py-2.5' className='px-3 py-2.5'
/> />
@@ -559,7 +576,11 @@ const ProductionResultContent = ({ tabId }: ProductionResultTabProps) => {
<div className='w-px self-stretch bg-base-content/10' /> <div className='w-px self-stretch bg-base-content/10' />
<Icon icon='heroicons:chevron-down' width={14} height={14} /> <Icon
icon='heroicons:chevron-down'
width={14}
height={14}
/>
</div> </div>
</Button> </Button>
} }
@@ -587,23 +608,32 @@ const ProductionResultContent = ({ tabId }: ProductionResultTabProps) => {
</Dropdown> </Dropdown>
</div> </div>
); );
}, [setTabActions]);
useEffect(() => {
return () => {
clearTabActions(tabId);
};
}, [clearTabActions]);
return null;
};
}, [ }, [
tabId, tabId,
filterParams, filterParams,
isAnyExportLoading, isAnyExportLoading,
exportToExcelHandler, exportToExcelHandler,
exportToPdfHandler, exportToPdfHandler,
setTabActions, isExcelExportLoading,
isPdfExportLoading,
]); ]);
useEffect(() => { // Render the TabActions component
return () => { const TabActionsElement = useMemo(() => <TabActions />, [TabActions]);
clearTabActions(tabId);
};
}, [tabId, clearTabActions]);
return ( return (
<> <>
{TabActionsElement}
<div className='w-full p-0 sm:p-3 flex flex-col gap-3'> <div className='w-full p-0 sm:p-3 flex flex-col gap-3'>
{!isSubmitted ? ( {!isSubmitted ? (
<ProductionResultSkeleton <ProductionResultSkeleton