gitea-admin/lti-web-client
1
0
Fork 0
mirror of https://gitlab.com/mbugroup/lti-web-client.git synced 2026-05-24 07:15:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(FE-208,212): rename getPurchaseItemError to isRepeaterInputError for clarity in validation checks

Browse Source
This commit is contained in:
rstubryan
2025-11-18 23:13:15 +07:00
parent 25544e2e38
commit 17378d8408
3 changed files with 31 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/components/pages/purchase/form/order/PurchaseOrderAcceptApprovalForm.tsx
+21 -21
View File
@@ -67,7 +67,7 @@ const PurchaseOrderAcceptApprovalForm = ({
} }
// ===== UTILITY FUNCTIONS ===== // ===== UTILITY FUNCTIONS =====
const getPurchaseItemError = ( const isRepeaterInputError = (
idx: number, idx: number,
field: field:
| 'purchase_item_id' | 'purchase_item_id'
@@ -410,10 +410,10 @@ const PurchaseOrderAcceptApprovalForm = ({
onChange={(val) => purchaseItemChangeHandler(idx, val)} onChange={(val) => purchaseItemChangeHandler(idx, val)}
options={getPurchaseItemOptions()} options={getPurchaseItemOptions()}
isError={ isError={
getPurchaseItemError(idx, 'purchase_item_id').isError isRepeaterInputError(idx, 'purchase_item_id').isError
} }
errorMessage={ errorMessage={
getPurchaseItemError(idx, 'purchase_item_id') isRepeaterInputError(idx, 'purchase_item_id')
.errorMessage .errorMessage
} }
placeholder='Pilih Item...' placeholder='Pilih Item...'
@@ -436,10 +436,10 @@ const PurchaseOrderAcceptApprovalForm = ({
} }
onBlur={formik.handleBlur} onBlur={formik.handleBlur}
isError={ isError={
getPurchaseItemError(idx, 'received_date').isError isRepeaterInputError(idx, 'received_date').isError
} }
errorMessage={ errorMessage={
getPurchaseItemError(idx, 'received_date') isRepeaterInputError(idx, 'received_date')
.errorMessage .errorMessage
} }
className={{ className={{
@@ -456,10 +456,10 @@ const PurchaseOrderAcceptApprovalForm = ({
onChange={(val) => warehouseChangeHandler(idx, val)} onChange={(val) => warehouseChangeHandler(idx, val)}
options={getWarehouseOptions()} options={getWarehouseOptions()}
isError={ isError={
getPurchaseItemError(idx, 'warehouse_id').isError isRepeaterInputError(idx, 'warehouse_id').isError
} }
errorMessage={ errorMessage={
getPurchaseItemError(idx, 'warehouse_id').errorMessage isRepeaterInputError(idx, 'warehouse_id').errorMessage
} }
placeholder='Pilih Gudang...' placeholder='Pilih Gudang...'
className={{ className={{
@@ -481,10 +481,10 @@ const PurchaseOrderAcceptApprovalForm = ({
} }
onBlur={formik.handleBlur} onBlur={formik.handleBlur}
isError={ isError={
getPurchaseItemError(idx, 'travel_number').isError isRepeaterInputError(idx, 'travel_number').isError
} }
errorMessage={ errorMessage={
getPurchaseItemError(idx, 'travel_number') isRepeaterInputError(idx, 'travel_number')
.errorMessage .errorMessage
} }
placeholder='Masukkan no. surat jalan' placeholder='Masukkan no. surat jalan'
@@ -507,11 +507,11 @@ const PurchaseOrderAcceptApprovalForm = ({
} }
onBlur={formik.handleBlur} onBlur={formik.handleBlur}
isError={ isError={
getPurchaseItemError(idx, 'travel_document_path') isRepeaterInputError(idx, 'travel_document_path')
.isError .isError
} }
errorMessage={ errorMessage={
getPurchaseItemError(idx, 'travel_document_path') isRepeaterInputError(idx, 'travel_document_path')
.errorMessage .errorMessage
} }
placeholder='Masukkan path dokumen' placeholder='Masukkan path dokumen'
@@ -534,10 +534,10 @@ const PurchaseOrderAcceptApprovalForm = ({
} }
onBlur={formik.handleBlur} onBlur={formik.handleBlur}
isError={ isError={
getPurchaseItemError(idx, 'vehicle_number').isError isRepeaterInputError(idx, 'vehicle_number').isError
} }
errorMessage={ errorMessage={
getPurchaseItemError(idx, 'vehicle_number') isRepeaterInputError(idx, 'vehicle_number')
.errorMessage .errorMessage
} }
placeholder='Masukkan nomor kendaraan' placeholder='Masukkan nomor kendaraan'
@@ -557,11 +557,11 @@ const PurchaseOrderAcceptApprovalForm = ({
} }
options={getExpeditionVendorOptions()} options={getExpeditionVendorOptions()}
isError={ isError={
getPurchaseItemError(idx, 'expedition_vendor_id') isRepeaterInputError(idx, 'expedition_vendor_id')
.isError .isError
} }
errorMessage={ errorMessage={
getPurchaseItemError(idx, 'expedition_vendor_id') isRepeaterInputError(idx, 'expedition_vendor_id')
.errorMessage .errorMessage
} }
placeholder='Pilih Vendor...' placeholder='Pilih Vendor...'
@@ -589,10 +589,10 @@ const PurchaseOrderAcceptApprovalForm = ({
thousandSeparator=',' thousandSeparator=','
decimalSeparator='.' decimalSeparator='.'
isError={ isError={
getPurchaseItemError(idx, 'received_qty').isError isRepeaterInputError(idx, 'received_qty').isError
} }
errorMessage={ errorMessage={
getPurchaseItemError(idx, 'received_qty').errorMessage isRepeaterInputError(idx, 'received_qty').errorMessage
} }
className={{ className={{
wrapper: 'min-w-40 md:min-w-52 lg:min-w-64', wrapper: 'min-w-40 md:min-w-52 lg:min-w-64',
@@ -619,11 +619,11 @@ const PurchaseOrderAcceptApprovalForm = ({
decimalSeparator='.' decimalSeparator='.'
inputPrefix={'Rp'} inputPrefix={'Rp'}
isError={ isError={
getPurchaseItemError(idx, 'transport_per_item') isRepeaterInputError(idx, 'transport_per_item')
.isError .isError
} }
errorMessage={ errorMessage={
getPurchaseItemError(idx, 'transport_per_item') isRepeaterInputError(idx, 'transport_per_item')
.errorMessage .errorMessage
} }
className={{ className={{
@@ -651,10 +651,10 @@ const PurchaseOrderAcceptApprovalForm = ({
decimalSeparator='.' decimalSeparator='.'
inputPrefix={'Rp'} inputPrefix={'Rp'}
isError={ isError={
getPurchaseItemError(idx, 'transport_total').isError isRepeaterInputError(idx, 'transport_total').isError
} }
errorMessage={ errorMessage={
getPurchaseItemError(idx, 'transport_total') isRepeaterInputError(idx, 'transport_total')
.errorMessage .errorMessage
} }
className={{ className={{
src/components/pages/purchase/form/order/PurchaseOrderStaffApprovalForm.tsx
+5 -5
View File
@@ -46,7 +46,7 @@ const PurchaseOrderStaffApprovalForm = ({
return currentStep >= 3; return currentStep >= 3;
}, [initialValues?.approval]); }, [initialValues?.approval]);
const getPurchaseItemError = ( const isRepeaterInputError = (
idx: number, idx: number,
field: 'price' | 'total_price' field: 'price' | 'total_price'
): { isError: boolean; errorMessage: string } => { ): { isError: boolean; errorMessage: string } => {
@@ -385,9 +385,9 @@ const PurchaseOrderStaffApprovalForm = ({
thousandSeparator=',' thousandSeparator=','
decimalSeparator='.' decimalSeparator='.'
inputPrefix={'Rp'} inputPrefix={'Rp'}
isError={getPurchaseItemError(idx, 'price').isError} isError={isRepeaterInputError(idx, 'price').isError}
errorMessage={ errorMessage={
getPurchaseItemError(idx, 'price').errorMessage isRepeaterInputError(idx, 'price').errorMessage
} }
className={{ className={{
wrapper: 'min-w-48 md:min-w-64 lg:min-w-72', wrapper: 'min-w-48 md:min-w-64 lg:min-w-72',
@@ -414,10 +414,10 @@ const PurchaseOrderStaffApprovalForm = ({
decimalSeparator='.' decimalSeparator='.'
inputPrefix={'Rp'} inputPrefix={'Rp'}
isError={ isError={
getPurchaseItemError(idx, 'total_price').isError isRepeaterInputError(idx, 'total_price').isError
} }
errorMessage={ errorMessage={
getPurchaseItemError(idx, 'total_price') isRepeaterInputError(idx, 'total_price')
.errorMessage .errorMessage
} }
className={{ className={{
src/components/pages/purchase/form/request/PurchaseRequestForm.tsx
+5 -5
View File
@@ -72,7 +72,7 @@ const PurchaseRequestForm = ({
} }
// ===== UTILITY FUNCTIONS ===== // ===== UTILITY FUNCTIONS =====
const getPurchaseItemError = ( const isRepeaterInputError = (
idx: number, idx: number,
field: 'product_warehouse_id' | 'product_id' | 'qty' field: 'product_warehouse_id' | 'product_id' | 'qty'
): { isError: boolean; errorMessage: string } => { ): { isError: boolean; errorMessage: string } => {
@@ -784,11 +784,11 @@ const PurchaseRequestForm = ({
options={getProductWarehouseOptionsForItem()} options={getProductWarehouseOptionsForItem()}
isLoading={isLoadingProductWarehouses} isLoading={isLoadingProductWarehouses}
isError={ isError={
getPurchaseItemError(idx, 'product_warehouse_id') isRepeaterInputError(idx, 'product_warehouse_id')
.isError .isError
} }
errorMessage={ errorMessage={
getPurchaseItemError(idx, 'product_warehouse_id') isRepeaterInputError(idx, 'product_warehouse_id')
.errorMessage .errorMessage
} }
isDisabled={ isDisabled={
@@ -820,9 +820,9 @@ const PurchaseRequestForm = ({
readOnly={type === 'detail'} readOnly={type === 'detail'}
allowNegative={false} allowNegative={false}
decimalScale={0} decimalScale={0}
isError={getPurchaseItemError(idx, 'qty').isError} isError={isRepeaterInputError(idx, 'qty').isError}
errorMessage={ errorMessage={
getPurchaseItemError(idx, 'qty').errorMessage isRepeaterInputError(idx, 'qty').errorMessage
} }
className={{ className={{
wrapper: 'min-w-24', wrapper: 'min-w-24',