From 17378d8408bf6cb41cfaad02017f248fe0e3e2c8 Mon Sep 17 00:00:00 2001 From: rstubryan Date: Tue, 18 Nov 2025 23:13:15 +0700 Subject: [PATCH] refactor(FE-208,212): rename getPurchaseItemError to isRepeaterInputError for clarity in validation checks --- .../order/PurchaseOrderAcceptApprovalForm.tsx | 42 +++++++++---------- .../order/PurchaseOrderStaffApprovalForm.tsx | 10 ++--- .../form/request/PurchaseRequestForm.tsx | 10 ++--- 3 files changed, 31 insertions(+), 31 deletions(-) diff --git a/src/components/pages/purchase/form/order/PurchaseOrderAcceptApprovalForm.tsx b/src/components/pages/purchase/form/order/PurchaseOrderAcceptApprovalForm.tsx index cfe52d8a..190f9599 100644 --- a/src/components/pages/purchase/form/order/PurchaseOrderAcceptApprovalForm.tsx +++ b/src/components/pages/purchase/form/order/PurchaseOrderAcceptApprovalForm.tsx @@ -67,7 +67,7 @@ const PurchaseOrderAcceptApprovalForm = ({ } // ===== UTILITY FUNCTIONS ===== - const getPurchaseItemError = ( + const isRepeaterInputError = ( idx: number, field: | 'purchase_item_id' @@ -410,10 +410,10 @@ const PurchaseOrderAcceptApprovalForm = ({ onChange={(val) => purchaseItemChangeHandler(idx, val)} options={getPurchaseItemOptions()} isError={ - getPurchaseItemError(idx, 'purchase_item_id').isError + isRepeaterInputError(idx, 'purchase_item_id').isError } errorMessage={ - getPurchaseItemError(idx, 'purchase_item_id') + isRepeaterInputError(idx, 'purchase_item_id') .errorMessage } placeholder='Pilih Item...' @@ -436,10 +436,10 @@ const PurchaseOrderAcceptApprovalForm = ({ } onBlur={formik.handleBlur} isError={ - getPurchaseItemError(idx, 'received_date').isError + isRepeaterInputError(idx, 'received_date').isError } errorMessage={ - getPurchaseItemError(idx, 'received_date') + isRepeaterInputError(idx, 'received_date') .errorMessage } className={{ @@ -456,10 +456,10 @@ const PurchaseOrderAcceptApprovalForm = ({ onChange={(val) => warehouseChangeHandler(idx, val)} options={getWarehouseOptions()} isError={ - getPurchaseItemError(idx, 'warehouse_id').isError + isRepeaterInputError(idx, 'warehouse_id').isError } errorMessage={ - getPurchaseItemError(idx, 'warehouse_id').errorMessage + isRepeaterInputError(idx, 'warehouse_id').errorMessage } placeholder='Pilih Gudang...' className={{ @@ -481,10 +481,10 @@ const PurchaseOrderAcceptApprovalForm = ({ } onBlur={formik.handleBlur} isError={ - getPurchaseItemError(idx, 'travel_number').isError + isRepeaterInputError(idx, 'travel_number').isError } errorMessage={ - getPurchaseItemError(idx, 'travel_number') + isRepeaterInputError(idx, 'travel_number') .errorMessage } placeholder='Masukkan no. surat jalan' @@ -507,11 +507,11 @@ const PurchaseOrderAcceptApprovalForm = ({ } onBlur={formik.handleBlur} isError={ - getPurchaseItemError(idx, 'travel_document_path') + isRepeaterInputError(idx, 'travel_document_path') .isError } errorMessage={ - getPurchaseItemError(idx, 'travel_document_path') + isRepeaterInputError(idx, 'travel_document_path') .errorMessage } placeholder='Masukkan path dokumen' @@ -534,10 +534,10 @@ const PurchaseOrderAcceptApprovalForm = ({ } onBlur={formik.handleBlur} isError={ - getPurchaseItemError(idx, 'vehicle_number').isError + isRepeaterInputError(idx, 'vehicle_number').isError } errorMessage={ - getPurchaseItemError(idx, 'vehicle_number') + isRepeaterInputError(idx, 'vehicle_number') .errorMessage } placeholder='Masukkan nomor kendaraan' @@ -557,11 +557,11 @@ const PurchaseOrderAcceptApprovalForm = ({ } options={getExpeditionVendorOptions()} isError={ - getPurchaseItemError(idx, 'expedition_vendor_id') + isRepeaterInputError(idx, 'expedition_vendor_id') .isError } errorMessage={ - getPurchaseItemError(idx, 'expedition_vendor_id') + isRepeaterInputError(idx, 'expedition_vendor_id') .errorMessage } placeholder='Pilih Vendor...' @@ -589,10 +589,10 @@ const PurchaseOrderAcceptApprovalForm = ({ thousandSeparator=',' decimalSeparator='.' isError={ - getPurchaseItemError(idx, 'received_qty').isError + isRepeaterInputError(idx, 'received_qty').isError } errorMessage={ - getPurchaseItemError(idx, 'received_qty').errorMessage + isRepeaterInputError(idx, 'received_qty').errorMessage } className={{ wrapper: 'min-w-40 md:min-w-52 lg:min-w-64', @@ -619,11 +619,11 @@ const PurchaseOrderAcceptApprovalForm = ({ decimalSeparator='.' inputPrefix={'Rp'} isError={ - getPurchaseItemError(idx, 'transport_per_item') + isRepeaterInputError(idx, 'transport_per_item') .isError } errorMessage={ - getPurchaseItemError(idx, 'transport_per_item') + isRepeaterInputError(idx, 'transport_per_item') .errorMessage } className={{ @@ -651,10 +651,10 @@ const PurchaseOrderAcceptApprovalForm = ({ decimalSeparator='.' inputPrefix={'Rp'} isError={ - getPurchaseItemError(idx, 'transport_total').isError + isRepeaterInputError(idx, 'transport_total').isError } errorMessage={ - getPurchaseItemError(idx, 'transport_total') + isRepeaterInputError(idx, 'transport_total') .errorMessage } className={{ diff --git a/src/components/pages/purchase/form/order/PurchaseOrderStaffApprovalForm.tsx b/src/components/pages/purchase/form/order/PurchaseOrderStaffApprovalForm.tsx index 02421c5f..88a9773d 100644 --- a/src/components/pages/purchase/form/order/PurchaseOrderStaffApprovalForm.tsx +++ b/src/components/pages/purchase/form/order/PurchaseOrderStaffApprovalForm.tsx @@ -46,7 +46,7 @@ const PurchaseOrderStaffApprovalForm = ({ return currentStep >= 3; }, [initialValues?.approval]); - const getPurchaseItemError = ( + const isRepeaterInputError = ( idx: number, field: 'price' | 'total_price' ): { isError: boolean; errorMessage: string } => { @@ -385,9 +385,9 @@ const PurchaseOrderStaffApprovalForm = ({ thousandSeparator=',' decimalSeparator='.' inputPrefix={'Rp'} - isError={getPurchaseItemError(idx, 'price').isError} + isError={isRepeaterInputError(idx, 'price').isError} errorMessage={ - getPurchaseItemError(idx, 'price').errorMessage + isRepeaterInputError(idx, 'price').errorMessage } className={{ wrapper: 'min-w-48 md:min-w-64 lg:min-w-72', @@ -414,10 +414,10 @@ const PurchaseOrderStaffApprovalForm = ({ decimalSeparator='.' inputPrefix={'Rp'} isError={ - getPurchaseItemError(idx, 'total_price').isError + isRepeaterInputError(idx, 'total_price').isError } errorMessage={ - getPurchaseItemError(idx, 'total_price') + isRepeaterInputError(idx, 'total_price') .errorMessage } className={{ diff --git a/src/components/pages/purchase/form/request/PurchaseRequestForm.tsx b/src/components/pages/purchase/form/request/PurchaseRequestForm.tsx index 2b6fd5ee..462a5dec 100644 --- a/src/components/pages/purchase/form/request/PurchaseRequestForm.tsx +++ b/src/components/pages/purchase/form/request/PurchaseRequestForm.tsx @@ -72,7 +72,7 @@ const PurchaseRequestForm = ({ } // ===== UTILITY FUNCTIONS ===== - const getPurchaseItemError = ( + const isRepeaterInputError = ( idx: number, field: 'product_warehouse_id' | 'product_id' | 'qty' ): { isError: boolean; errorMessage: string } => { @@ -784,11 +784,11 @@ const PurchaseRequestForm = ({ options={getProductWarehouseOptionsForItem()} isLoading={isLoadingProductWarehouses} isError={ - getPurchaseItemError(idx, 'product_warehouse_id') + isRepeaterInputError(idx, 'product_warehouse_id') .isError } errorMessage={ - getPurchaseItemError(idx, 'product_warehouse_id') + isRepeaterInputError(idx, 'product_warehouse_id') .errorMessage } isDisabled={ @@ -820,9 +820,9 @@ const PurchaseRequestForm = ({ readOnly={type === 'detail'} allowNegative={false} decimalScale={0} - isError={getPurchaseItemError(idx, 'qty').isError} + isError={isRepeaterInputError(idx, 'qty').isError} errorMessage={ - getPurchaseItemError(idx, 'qty').errorMessage + isRepeaterInputError(idx, 'qty').errorMessage } className={{ wrapper: 'min-w-24',